Make Maxdiffusion compatile w/ JAX 0.7.0 and latest orbax version#211
Merged
Make Maxdiffusion compatile w/ JAX 0.7.0 and latest orbax version#211
Conversation
entrpn
previously approved these changes
Jul 28, 2025
Rohan-Bierneni
changed the title
entrpn
previously approved these changes
Jul 28, 2025
coolkp
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix allows us to use the latest version of orbax. Use these changes to test maxdiffusion + jax 0.7.0 + python 3.12. Only merge these changes once unit tests and XLML tests pass.
A maxdiffusion docker image with these changes already made is here and a maxdiffusion without the orbax changes is here.
Logs from failing XLML DAG with updated orbax API: https://paste.googleplex.com/5559411468402688#l=348
Update:
Tested that a sdxl workload now passes using the image w/ JAX 0.7.0 and latest orbax.
https://screenshot.googleplex.com/8ga2wtDFyeWkiZJ
https://screenshot.googleplex.com/6BfijSpUf6Me4rS