Skip to content

add g++ compiler to base image and implement hardware-aware FeedForward sharding#413

Merged
copybara-service[bot] merged 1 commit into
mainfrom
prisha/img_fix
May 21, 2026
Merged

add g++ compiler to base image and implement hardware-aware FeedForward sharding#413
copybara-service[bot] merged 1 commit into
mainfrom
prisha/img_fix

Conversation

@prishajain1
Copy link
Copy Markdown
Collaborator

This PR introduces setup changes and optimizations needed to fix WAN trillium regression tests:

  • Pre-baked g++ into the base system dependencies list. This provides the C++ compiler required by PyTorch Inductor (torch.compile) to compile the T5 text encoder at runtime, resolving the InvalidCxxCompiler error.
  • Hardware-Aware Dynamic Sharding : Implemented dynamic, hardware-aware sharding inside NNXSimpleFeedForward:
    • Default (including Trillium/v6e): Shards embed to distribute memory and prevent OOM during high-resolution passes.
    • Ironwood (v7x): Keeps the embedding dimension replicated (None) to optimize cross-device communication bandwidth.

@prishajain1 prishajain1 requested a review from entrpn as a code owner May 20, 2026 18:00
@github-actions
Copy link
Copy Markdown

Perseus14
Perseus14 previously approved these changes May 20, 2026
@Perseus14
Copy link
Copy Markdown
Collaborator

Can you also add the python package av? This is required for ltx2 model post processing

@copybara-service copybara-service Bot merged commit 2ad2bcf into main May 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants