Add multiple retries to load data in multihost_dataloading#13
Merged
Conversation
rwitten
approved these changes
Apr 24, 2023
Collaborator
rwitten
left a comment
rwitten
left a comment
There was a problem hiding this comment.
nits actually included this time.
| max_logging.log("Failed to get next data batch, retrying") | ||
| time.sleep(10) | ||
| loaded_data_success = False | ||
| data_load_attempts, max_data_load_attempts = 0, 30 |
Collaborator
There was a problem hiding this comment.
nit: putthing these constants into uppercase (and including a the time.sleep constant) would be better
| loaded_data_success = False | ||
| data_load_attempts, max_data_load_attempts = 0, 30 | ||
| while not loaded_data_success and data_load_attempts < max_data_load_attempts: | ||
| data_load_attempts = data_load_attempts + 1 |
A9isha
pushed a commit
that referenced
this pull request
Apr 11, 2024
phu0ngng
pushed a commit
to phu0ngng/maxtext
that referenced
this pull request
Aug 18, 2025
…rchtold/error-when-dropout-used-in-mlp Raise error when dropout used in TE mlp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested via: