Update MaxEngine to optionally return token log probability#1626
Merged
Conversation
bvandermoon
reviewed
Apr 24, 2025
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
Do you know why the gpu_unit_tests are failing with this change?
FAILED MaxText/tests/decode_tests.py::DecodeTests::test_gpu_base - TypeError: ResultTokens.__init__() got an unexpected keyword argument 'log_prob'
FAILED MaxText/tests/decode_tests.py::DecodeTests::test_gpu_int8 - TypeError: ResultTokens.__init__() got an unexpected keyword argument 'log_prob'
FAILED MaxText/tests/decode_tests.py::DecodeTests::test_gpu_pdb_lt_1 - TypeError: ResultTokens.__init__() got an unexpected keyword argument 'log_prob'
FAILED MaxText/tests/maxengine_test.py::MaxEngineTest::test_basic_prefill - TypeError: ResultTokens.__init__() got an unexpected keyword argument 'log_prob'
Collaborator
Author
The Jetstream PR has to go through first, since it updates the |
A9isha
reviewed
Apr 24, 2025
4b63c1c to
636bd2b
Compare
mitalisi
approved these changes
Apr 25, 2025
khatwanimohit
approved these changes
Apr 25, 2025
3f70317 to
67b8223
Compare
Collaborator
|
This PR includes changes from many other PRs which are already landed and its hard to read the specific code chagnes. Can you rebase your branch and update this PR? |
6561b8c to
53e2cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR and AI-Hypercomputer/JetStream#260 together enables MaxEngine to return token log probability when
return_log_probis set toTruein the global config.This change is needed for calculating GRPO loss.
Tests
Manually tested
Checklist
Before submitting this PR, please make sure (put X in square brackets):