-
Notifications
You must be signed in to change notification settings - Fork 438
fix github clone link #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix github clone link #1807
Conversation
SurbhiJainUSC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also fix here, please? Thank you!
Hi @SurbhiJainUSC , actually this one works as it is auto redirected to current repo link. I guess we can leave it as is, but please let me know if you prefer a change to make it more clear. $ git clone https://github.com/google/maxtext.git
Cloning into 'maxtext'...
remote: Enumerating objects: 45129, done.
remote: Counting objects: 100% (2445/2445), done.
remote: Compressing objects: 100% (1033/1033), done.
remote: Total 45129 (delta 2086), reused 1425 (delta 1411), pack-reused 42684 (from 3)
Receiving objects: 100% (45129/45129), 308.69 MiB | 10.21 MiB/s, done.
Resolving deltas: 100% (33126/33126), done. |
Yes, it does redirect to the actual link. IMO, it would be better to have consistency in our codebase. |
99cd240 to
7979074
Compare
Done the change. Thanks for reviewing the PR! |
|
Adding pull ready manually so we don't need bother with an inference reviewer (since this is a straightforward readme change) |
Description
Fix the maxtext repo link in clone cli.
Users without maintainer access to the repo cannot clone with the cli.
If the change fixes a bug or a Github issue, please include a link, e.g.,:
N/A
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Local run.
Checklist
Before submitting this PR, please make sure (put X in square brackets):