Skip to content

Conversation

@junjieqian
Copy link
Contributor

Description

Fix the maxtext repo link in clone cli.
Users without maintainer access to the repo cannot clone with the cli.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
N/A

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Local run.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@SurbhiJainUSC SurbhiJainUSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix here, please? Thank you!

@junjieqian
Copy link
Contributor Author

Can you also fix here, please? Thank you!

Hi @SurbhiJainUSC , actually this one works as it is auto redirected to current repo link. I guess we can leave it as is, but please let me know if you prefer a change to make it more clear.
thanks

$ git clone https://github.com/google/maxtext.git
Cloning into 'maxtext'...
remote: Enumerating objects: 45129, done.
remote: Counting objects: 100% (2445/2445), done.
remote: Compressing objects: 100% (1033/1033), done.
remote: Total 45129 (delta 2086), reused 1425 (delta 1411), pack-reused 42684 (from 3)
Receiving objects: 100% (45129/45129), 308.69 MiB | 10.21 MiB/s, done.
Resolving deltas: 100% (33126/33126), done.

@SurbhiJainUSC
Copy link
Collaborator

Can you also fix here, please? Thank you!

Hi @SurbhiJainUSC , actually this one works as it is auto redirected to current repo link. I guess we can leave it as is, but please let me know if you prefer a change to make it more clear. thanks

$ git clone https://github.com/google/maxtext.git
Cloning into 'maxtext'...
remote: Enumerating objects: 45129, done.
remote: Counting objects: 100% (2445/2445), done.
remote: Compressing objects: 100% (1033/1033), done.
remote: Total 45129 (delta 2086), reused 1425 (delta 1411), pack-reused 42684 (from 3)
Receiving objects: 100% (45129/45129), 308.69 MiB | 10.21 MiB/s, done.
Resolving deltas: 100% (33126/33126), done.

Yes, it does redirect to the actual link. IMO, it would be better to have consistency in our codebase.

@junjieqian
Copy link
Contributor Author

Can you also fix here, please? Thank you!

Hi @SurbhiJainUSC , actually this one works as it is auto redirected to current repo link. I guess we can leave it as is, but please let me know if you prefer a change to make it more clear. thanks

$ git clone https://github.com/google/maxtext.git
Cloning into 'maxtext'...
remote: Enumerating objects: 45129, done.
remote: Counting objects: 100% (2445/2445), done.
remote: Compressing objects: 100% (1033/1033), done.
remote: Total 45129 (delta 2086), reused 1425 (delta 1411), pack-reused 42684 (from 3)
Receiving objects: 100% (45129/45129), 308.69 MiB | 10.21 MiB/s, done.
Resolving deltas: 100% (33126/33126), done.

Yes, it does redirect to the actual link. IMO, it would be better to have consistency in our codebase.

Done the change. Thanks for reviewing the PR!

@gobbleturk
Copy link
Collaborator

Adding pull ready manually so we don't need bother with an inference reviewer (since this is a straightforward readme change)

@copybara-service copybara-service bot merged commit 216c3d0 into AI-Hypercomputer:main Jul 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants