Skip to content

Conversation

@Obliviour
Copy link
Collaborator

@Obliviour Obliviour commented Nov 13, 2025

Description

For two goals

  1. Help with changes in max xpk runner and related workflows
  2. Work on a customer facing test MaxTest in that directory and needs help getting approvals and I am familiar with that work

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

NA

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

For two goals

1. Help with changes in max xpk runner and related workflows 
2. Work on a customer facing test MaxTest in that directory and needs help getting approvals and I am familiar with that work
Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@copybara-service copybara-service bot merged commit 67f43b8 into main Nov 13, 2025
38 of 39 checks passed
@copybara-service copybara-service bot deleted the codeowner-change branch November 13, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants