-
Notifications
You must be signed in to change notification settings - Fork 433
Add a blurb for DeepSeek v3 fine-tuning FP8 Recipe #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RissyRan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, LGTM overall! Thank you
suexu1025
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BirdsOfAFthr! Could you also briefly include the specific details of the recipe? Like clarify the FW/BW FP8 formats, the quantization granularity used here, and how this configuration was validated regarding convergence.
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This Pull Request introduces a new section documenting the DeepSeek V3 Fine-tuning FP8 Recipe. The content is well-structured and provides valuable information regarding the quantization scope, FP8 recipe, convergence, and performance sensitivity.
🔍 General Feedback
- The new documentation is clear and informative, enhancing the overall quality of the
quantization.mdfile.
RissyRan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 3 minor comments.
Description
Add a blurb for DeepSeek v3 fine-tuning FP8 Recipe.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.