Skip to content

Conversation

@BirdsOfAFthr
Copy link
Collaborator

Description

Add a blurb for DeepSeek v3 fine-tuning FP8 Recipe.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, LGTM overall! Thank you

Copy link
Collaborator

@suexu1025 suexu1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BirdsOfAFthr! Could you also briefly include the specific details of the recipe? Like clarify the FW/BW FP8 formats, the quantization granularity used here, and how this configuration was validated regarding convergence.

@github-actions
Copy link

🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This Pull Request introduces a new section documenting the DeepSeek V3 Fine-tuning FP8 Recipe. The content is well-structured and provides valuable information regarding the quantization scope, FP8 recipe, convergence, and performance sensitivity.

🔍 General Feedback

  • The new documentation is clear and informative, enhancing the overall quality of the quantization.md file.

Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 3 minor comments.

@copybara-service copybara-service bot merged commit 142b565 into main Nov 22, 2025
33 of 38 checks passed
@copybara-service copybara-service bot deleted the BirdsOfAFthr-patch-1 branch November 22, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants