Skip to content

add low_rank checkpoint#2811

Merged
copybara-service[bot] merged 1 commit intomainfrom
qinwen/add_ckpt_mla
Dec 11, 2025
Merged

add low_rank checkpoint#2811
copybara-service[bot] merged 1 commit intomainfrom
qinwen/add_ckpt_mla

Conversation

@suexu1025
Copy link
Copy Markdown
Collaborator

@suexu1025 suexu1025 commented Dec 11, 2025

Description

  1. add checkpoint option to checkpoint mla_q and mla_kv to save the offload bandwidth.
  2. run results
    http://xprof/?session_id=qinwen-6255752584571932633

verified the tensor is with [1536, x] instead of [128,128, x] sizing.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/467787265

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@suexu1025 suexu1025 assigned suexu1025 and unassigned suexu1025 Dec 11, 2025
@copybara-service copybara-service Bot merged commit 5d5eeb5 into main Dec 11, 2025
43 of 44 checks passed
@copybara-service copybara-service Bot deleted the qinwen/add_ckpt_mla branch December 11, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants