Fix Gpt3 MultiHeadAttention out projection dimension#2812
Merged
copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom Dec 11, 2025
Merged
Conversation
RissyRan
approved these changes
Dec 11, 2025
gobbleturk
approved these changes
Dec 11, 2025
a581e00
into
AI-Hypercomputer:main
127 of 133 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The output dimension of the output projection in the Gpt3 MultiHeadAttention layer is mistakenly set to
self.num_heads * self.head_dim; it should beconfig.emb_dim.Tests
Logs: base_emb_dim=3584
Logs: base_emb_dim=3584 base_mlp_dim=3584
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.