Skip to content

Update device numbers in tpu7x characteristics#2894

Merged
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-update-7x
Dec 29, 2025
Merged

Update device numbers in tpu7x characteristics#2894
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-update-7x

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Dec 29, 2025

Description

Since for tpu7x the number of devices is equivalent with the number of cores (double of the number of chips), we should update the system characteristics accordingly. This PR also updates train_compile tests to verify.

Tests

train compile test

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@NuojCheng NuojCheng force-pushed the chengnuojin-update-7x branch from 68865d1 to f654abe Compare December 29, 2025 17:30
@NuojCheng NuojCheng force-pushed the chengnuojin-update-7x branch from f654abe to 6ce049e Compare December 29, 2025 17:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@copybara-service copybara-service Bot merged commit 37006c0 into main Dec 29, 2025
25 of 26 checks passed
@copybara-service copybara-service Bot deleted the chengnuojin-update-7x branch December 29, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants