Fix missing hf_eval_split option in test_convergence_1b_params.sh#2910
Merged
copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom Jan 8, 2026
Merged
Conversation
hf_eval_split option in test_convergence_1b_params.shhf_eval_split option in test_convergence_1b_params.sh
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gobbleturk
approved these changes
Jan 7, 2026
Collaborator
gobbleturk
left a comment
There was a problem hiding this comment.
Thank you for the fix!
NicoGrande
approved these changes
Jan 7, 2026
2af3ead
into
AI-Hypercomputer:main
23 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
hf_eval_splitmust be set when runningend_to_end/tpu/test_convergence_1b_params.sh, otherwise it will throwValueError: Bad split: . Available splits: ['train'].Error Log
Tests
~/xpk/xpk.py workload create --cluster=bodaborg-v6e-256-lcscld-c --workload=maxtext-convergence-hf-v6e-2569caf0631 --command='set -xue;export M_RUN_NAME=maxtext-convergence-hf-v6e-256-2026-01-05-06-36-59;bash end_to_end/tpu/test_convergence_1b_params.sh OUTPUT_PATH=gs://ml-auto-solutions/output/maxtext/stable/automated/2026-01-05 DATASET_PATH=gs://max-datasets-rogue LOSS_THRESHOLD=2.7 STEPS=500 PER_DEVICE_BATCH_SIZE=2.0 DATASET_TYPE=hf' --device-type=v6e-256 --num-slices=1 --docker-image=gcr.io/tpu-prod-env-multipod/maxtext_base_image:hf --project=tpu-prod-env-one-vm --zone=southamerica-west1-a --env GCS_OUTPUT=gs://ml-auto-solutions/output/unowned/maxtext-convergence-hf-v6e-256-2026-01-05-06-37-20/ --skip-validationLog
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.