Adding Support for Attention Sinks to vLLM Code Path.#2923
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 12, 2026
Merged
Adding Support for Attention Sinks to vLLM Code Path.#2923copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gagika
reviewed
Jan 9, 2026
6873337 to
27ce213
Compare
27ce213 to
e6976ba
Compare
gobbleturk
approved these changes
Jan 12, 2026
NuojCheng
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for attention sinks in the MaxText on vLLM codepath. This introduces support for the GPT-OSS family of models.
Tests
Tested locally on v6e-4 with the following command:
Output:
Note: GPT-OSS uses the harmony tokenizer with a special end token which is not used in vLLM by default. This is why we see repeated characters at the end of the response.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.