Skip to content

Fix rngs used for training#2938

Merged
copybara-service[bot] merged 1 commit intomainfrom
xibin/nnx
Jan 15, 2026
Merged

Fix rngs used for training#2938
copybara-service[bot] merged 1 commit intomainfrom
xibin/nnx

Conversation

@xibinliu
Copy link
Copy Markdown
Collaborator

@xibinliu xibinliu commented Jan 13, 2026

Description

Fix rngs used for training.
Also fix the unit tests to make them run in different tpu VMs

Tests

Run a training successfully.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/MaxText/maxtext_utils.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread tests/maxtext_utils_test.py Outdated
Comment thread tests/data_loader_test.py
Also fix the unit tests to make them run in different tpu VMs
@copybara-service copybara-service Bot merged commit 05bf24c into main Jan 15, 2026
26 of 28 checks passed
@copybara-service copybara-service Bot deleted the xibin/nnx branch January 15, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants