Skip to content

Fix fsdp2d ds logical rule#2940

Merged
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-fix-2dfsdp
Jan 14, 2026
Merged

Fix fsdp2d ds logical rule#2940
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-fix-2dfsdp

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Jan 14, 2026

Description

Current logical rule of fsdp2 deepseek does not support properly sharded batch data, which generates from MaxText.sharding.get_input_data_sharding. This PR adds logical rules and making sure input data are properly sharded.

Tests

CI

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@suexu1025 suexu1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NuojCheng !

@copybara-service copybara-service Bot merged commit 644eda6 into main Jan 14, 2026
32 of 33 checks passed
@copybara-service copybara-service Bot deleted the chengnuojin-fix-2dfsdp branch January 14, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants