Support NNX checkpoint conversion to HF#2946
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 16, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
5812b57 to
1837cbd
Compare
59b2503 to
1fe8fd3
Compare
shuningjin
approved these changes
Jan 15, 2026
Collaborator
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR further supports NNX-SFT and NNX-RL checkpoints conversion to HuggingFace safetensors format. For the same model, their structural difference can be seen in here:
{'params': {'params': {'decoder': {...}, 'token_embedder': ... {WEIGHT_ARRAY}}}}. This is the conventional MaxText structure that nests weights directly within a doubleparamswrapper.{'decoder': {...}, 'token_embedder': ... {'value': WEIGHT_ARRAY}}. This format removes the top-levelparamswrappers but adds avaluekey to contain the weights at every leaf node.{'base': {'decoder': {...}, 'token_embedder': ... {'value': WEIGHT_ARRAY}}}. Similar to the SFT structure, this format wraps the entire model under a top-levelbasekey while maintaining the leaf-levelvalueconvention.Changes in this PR:
maxenginewithocp.Checkpointerto load weights directly from the source, removing the dependency on MaxText model initialization.params-decoder-decoder_norm-scale.to_huggingfaceconversion process.Fixes: b/474525257, b/475223303
Tests
Tested conversion with all three Linen/NNX-SFT/NNX-RL checkpoints types to HuggingFace (v6e-8). Offline inference with HuggingFace scripts.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.