Add P.UNCONSTRAINED condition in remove size one mesh axis #2947
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 14, 2026
Merged
Add P.UNCONSTRAINED condition in remove size one mesh axis #2947copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
…o avoid program bugs
7a513c5 to
658ef16
Compare
khatwanimohit
approved these changes
Jan 14, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hengtaoguo
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For
MaxText.sharding.remove_size_one_mesh_axisfunction we always assume the given partition spec exists in mesh, but usingjax.sharding.PartitionSpec.UNCONSTRAINEDviolates this setting. This PR fixes this connor case to avoid possible bugs (mostly using pipeline parallelism +debug_sharding=True).Tests
Before change: https://paste.googleplex.com/6298233649364992
After change: https://paste.googleplex.com/6317784340496384
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.