Skip to content

Record maxtext & post-training requirements commit ids to CI workflow#2975

Merged
copybara-service[bot] merged 1 commit intomainfrom
rl_commit
Jan 23, 2026
Merged

Record maxtext & post-training requirements commit ids to CI workflow#2975
copybara-service[bot] merged 1 commit intomainfrom
rl_commit

Conversation

@SurbhiJainUSC
Copy link
Copy Markdown
Collaborator

@SurbhiJainUSC SurbhiJainUSC commented Jan 20, 2026

Description

  • Record maxtext & post-training requirements commit ids to CI workflow
  • Update RL documentation to use the commit ids from Github CI workflow

Tests

CI tests
https://screenshot.googleplex.com/3oGevk87kKJPhmQ

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread docs/tutorials/posttraining/rl.md Outdated
Comment thread docs/tutorials/posttraining/rl.md Outdated
Comment thread docs/tutorials/posttraining/rl.md Outdated
Comment thread docs/tutorials/posttraining/rl.md
@SurbhiJainUSC SurbhiJainUSC force-pushed the rl_commit branch 2 times, most recently from fb16e20 to dc303b4 Compare January 22, 2026 17:24
@github-actions
Copy link
Copy Markdown

🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This Pull Request effectively introduces the recording of maxtext and post-training dependency commit IDs into the CI workflows, and updates the relevant RL documentation to guide users on how to retrieve these commit IDs for consistent environment setup. The changes improve the reproducibility of RL experiments.

🔍 General Feedback

  • The workflow changes are well-implemented, ensuring the maxtext_sha is propagated correctly across dependent jobs.
  • The documentation updates significantly enhance clarity by providing explicit instructions on how to obtain compatible commit IDs from CI runs.
  • Consider reviewing the markdown line wrapping in the documentation for slightly improved flow and readability in certain sections, as noted in the inline comments.

Comment thread .github/workflows/build_package.yml
Comment thread docs/tutorials/posttraining/rl.md
Comment thread docs/tutorials/posttraining/rl_on_multi_host.md
Copy link
Copy Markdown
Collaborator

@A9isha A9isha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Surbhi!

Copy link
Copy Markdown
Collaborator

@khatwanimohit khatwanimohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! left a nit

Comment thread docs/tutorials/posttraining/rl.md
Comment thread docs/tutorials/posttraining/rl.md
@copybara-service copybara-service Bot merged commit 828b668 into main Jan 23, 2026
37 of 38 checks passed
@copybara-service copybara-service Bot deleted the rl_commit branch January 23, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants