Record maxtext & post-training requirements commit ids to CI workflow#2975
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 23, 2026
Merged
Record maxtext & post-training requirements commit ids to CI workflow#2975copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9093a88 to
779cdfd
Compare
8eb4c60 to
cb0b085
Compare
shralex
reviewed
Jan 21, 2026
shralex
reviewed
Jan 21, 2026
shralex
reviewed
Jan 21, 2026
cb0b085 to
466e0ef
Compare
604305e to
202c8c8
Compare
202c8c8 to
869253f
Compare
shralex
reviewed
Jan 22, 2026
fb16e20 to
dc303b4
Compare
dc303b4 to
d53b80f
Compare
|
🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
📋 Review Summary
This Pull Request effectively introduces the recording of maxtext and post-training dependency commit IDs into the CI workflows, and updates the relevant RL documentation to guide users on how to retrieve these commit IDs for consistent environment setup. The changes improve the reproducibility of RL experiments.
🔍 General Feedback
- The workflow changes are well-implemented, ensuring the
maxtext_shais propagated correctly across dependent jobs. - The documentation updates significantly enhance clarity by providing explicit instructions on how to obtain compatible commit IDs from CI runs.
- Consider reviewing the markdown line wrapping in the documentation for slightly improved flow and readability in certain sections, as noted in the inline comments.
khatwanimohit
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
CI tests
https://screenshot.googleplex.com/3oGevk87kKJPhmQ
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.