-
Notifications
You must be signed in to change notification settings - Fork 458
Move examples under maxtext/examples #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Great catch! :) |
0572e3a to
34441f1
Compare
34441f1 to
fdeee6d
Compare
37c98f5 to
661d6df
Compare
8191bd3 to
719e632
Compare
719e632 to
7a69d7c
Compare
7a69d7c to
232adf2
Compare
Open
4 tasks
49b8af7 to
a01dcad
Compare
khatwanimohit
approved these changes
Jan 30, 2026
Collaborator
khatwanimohit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a01dcad to
5840964
Compare
SurbhiJainUSC
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates and reorganizes the example notebooks and pedagogical scripts within the repository. Specifically, it moves files from
src/MaxText/examples/andpedagogical_examples/into a unifiedsrc/maxtext/examples/directory. All internal references, documentation links, and CI workflows have been updated to reflect these path changes.Key Changes
rl_llama3_demo.ipynb,sft_llama3_demo.ipynb,demo_decoding.ipynb) fromsrc/MaxText/examples/tosrc/maxtext/examples/.non_spmd.py,shardings.py,shmap_collective_matmul.py) from the top-levelpedagogical_examples/directory tosrc/maxtext/examples/..github/workflows/run_jupyter_notebooks.ymlto set the newMAXTEXT_NOTEBOOKS_ROOTpath and includesrcinPYTHONPATH.README.mdand various files indocs/to ensure links point to the new examples directory.rl.ymlconfiguration to point to the newchat_template_path.codecov.ymlto reflect the new directory structure for coverage ignore rules.Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.