Skip to content

Adding new sharding and performance args for vLLM#3020

Merged
copybara-service[bot] merged 1 commit intomainfrom
nicogrande/update-train-rl-args
Jan 30, 2026
Merged

Adding new sharding and performance args for vLLM#3020
copybara-service[bot] merged 1 commit intomainfrom
nicogrande/update-train-rl-args

Conversation

@NicoGrande
Copy link
Copy Markdown
Collaborator

@NicoGrande NicoGrande commented Jan 27, 2026

Description

This PR adds new flags to enable attn_dp in the vLLM mesh, as well as flags to tune the performance of vLLM generation. More information on these flags and their effects can be found here:
https://docs.vllm.ai/en/stable/configuration/optimization/#performance-tuning-with-chunked-prefill

Tests

Tested e2e RL workflow with new flags and updated Tunix code.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@NicoGrande NicoGrande force-pushed the nicogrande/update-train-rl-args branch from d5788f6 to 58cff0b Compare January 29, 2026 19:52
Copy link
Copy Markdown
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@copybara-service copybara-service Bot merged commit af14e43 into main Jan 30, 2026
42 checks passed
@copybara-service copybara-service Bot deleted the nicogrande/update-train-rl-args branch January 30, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants