Skip to content

Add MROPE support.#3085

Merged
copybara-service[bot] merged 1 commit intomainfrom
qwen-mrope_cont2
Feb 4, 2026
Merged

Add MROPE support.#3085
copybara-service[bot] merged 1 commit intomainfrom
qwen-mrope_cont2

Conversation

@entrpn
Copy link
Copy Markdown
Collaborator

@entrpn entrpn commented Feb 4, 2026

Original author @eitanporat in #2727

Description

Implemented multi-modal rope and integrated in training and inference

Tests

Compared to the pytorch implementation
tests/multimodal_rope_check.py

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Co-authored-by: Eitan Porat <eporat@lightricks.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

@copybara-service copybara-service Bot merged commit 02bc28c into main Feb 4, 2026
44 of 47 checks passed
@copybara-service copybara-service Bot deleted the qwen-mrope_cont2 branch February 4, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants