Skip to content

Fix pyconfig for post train#3126

Merged
copybara-service[bot] merged 1 commit intomainfrom
anisha-fix-pyconfig
Feb 12, 2026
Merged

Fix pyconfig for post train#3126
copybara-service[bot] merged 1 commit intomainfrom
anisha-fix-pyconfig

Conversation

@A9isha
Copy link
Copy Markdown
Collaborator

@A9isha A9isha commented Feb 12, 2026

Description

Fix pyconfig to look for "models" after refactoring of sft.yml and rl.yml inside src/maxtext/configs/post_train

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Tested locally on v5p-8 with

python3 -m maxtext.trainers.post_train.sft.train_sft src/maxtext/configs/post_train/sft.yml run_name=check model_name=llama3.1-8b tokenizer_path=meta-llama/Llama-3.1-8B-Instruct hf_access_token=<token> load_parameters_path=/path/to/checkpoint steps=10

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@A9isha A9isha force-pushed the anisha-fix-pyconfig branch 3 times, most recently from a2b8a7d to da8f46a Compare February 12, 2026 13:38
@A9isha A9isha force-pushed the anisha-fix-pyconfig branch from da8f46a to f683be3 Compare February 12, 2026 13:40
@copybara-service copybara-service Bot merged commit 1238d84 into main Feb 12, 2026
42 checks passed
@copybara-service copybara-service Bot deleted the anisha-fix-pyconfig branch February 12, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants