Updating config paths for MaxText on vLLM#3129
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
khatwanimohit
approved these changes
Feb 12, 2026
46f97eb to
e0953c8
Compare
bvandermoon
approved these changes
Feb 12, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
LGTM. Why was this causing duplicate KVCaches?
e0953c8 to
623ac0c
Compare
623ac0c to
3271c6b
Compare
bvandermoon
approved these changes
Feb 13, 2026
Collaborator
Author
This is probably taken care-of by Jax under the hood, but I wanted to avoid the possibility of having both the input KV cache and the updated KV cache in memory simultaneously in two separate variables. This is also how vLLM native models are implemented. |
3271c6b to
20a214f
Compare
changing config paths.
20a214f to
37d547d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the config paths used in MaxText on vLLM codepaths and removes circular import in
src/MaxText/__init__.py.This PR also overwrites the KV cache variable in
adapter.pyto avoid duplicating KV cache instances in memory.Tests
Running
vllm_decode.pyChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.