Skip to content

Updating config paths for MaxText on vLLM#3129

Merged
copybara-service[bot] merged 1 commit intomainfrom
nicogrande/duplicate-kv-cache
Feb 13, 2026
Merged

Updating config paths for MaxText on vLLM#3129
copybara-service[bot] merged 1 commit intomainfrom
nicogrande/duplicate-kv-cache

Conversation

@NicoGrande
Copy link
Copy Markdown
Collaborator

@NicoGrande NicoGrande commented Feb 12, 2026

Description

Updates the config paths used in MaxText on vLLM codepaths and removes circular import in src/MaxText/__init__.py.

This PR also overwrites the KV cache variable in adapter.py to avoid duplicating KV cache instances in memory.

Tests

Running vllm_decode.py

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...t/integration/vllm/maxtext_vllm_adapter/adapter.py 0.00% 4 Missing ⚠️
src/MaxText/rl/train_rl.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@NicoGrande NicoGrande force-pushed the nicogrande/duplicate-kv-cache branch from 46f97eb to e0953c8 Compare February 12, 2026 23:24
Copy link
Copy Markdown
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why was this causing duplicate KVCaches?

@NicoGrande NicoGrande force-pushed the nicogrande/duplicate-kv-cache branch from e0953c8 to 623ac0c Compare February 12, 2026 23:53
@NicoGrande NicoGrande changed the title removing duplicate KV cache instance. Updating config paths for MaxText on vLLM Feb 12, 2026
@NicoGrande NicoGrande force-pushed the nicogrande/duplicate-kv-cache branch from 623ac0c to 3271c6b Compare February 12, 2026 23:58
@NicoGrande
Copy link
Copy Markdown
Collaborator Author

LGTM. Why was this causing duplicate KVCaches?

This is probably taken care-of by Jax under the hood, but I wanted to avoid the possibility of having both the input KV cache and the updated KV cache in memory simultaneously in two separate variables. This is also how vLLM native models are implemented.

@NicoGrande NicoGrande force-pushed the nicogrande/duplicate-kv-cache branch from 3271c6b to 20a214f Compare February 13, 2026 00:13
@NicoGrande NicoGrande force-pushed the nicogrande/duplicate-kv-cache branch from 20a214f to 37d547d Compare February 13, 2026 00:45
@copybara-service copybara-service Bot merged commit 496ed40 into main Feb 13, 2026
29 of 30 checks passed
@copybara-service copybara-service Bot deleted the nicogrande/duplicate-kv-cache branch February 13, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants