Move pyconfig&pyconfig_deprecated to maxtext/configs#3266
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 27, 2026
Merged
Move pyconfig&pyconfig_deprecated to maxtext/configs#3266copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
hengtaoguo
force-pushed
the
hengtaoguo-pyconfig
branch
2 times, most recently
from
47d46d5 to
4bb4045
Compare
hengtaoguo
changed the title
hengtaoguo
changed the title
hengtaoguo
requested review from
A9isha,
Lumosis,
NicoGrande,
NuojCheng,
Obliviour,
RissyRan,
SujeethJinesh,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
jrplatin,
khatwanimohit,
mailvijayasingh,
mitalisi,
notabee,
parambole,
patemotter,
richjames0,
shauryagup,
shralex,
shuningjin,
suexu1025,
vipannalla and
xuefgu
as code owners
hengtaoguo
requested review from
SurbhiJainUSC,
aireenmei,
jesselu-google and
jiangjy1982
as code owners
hengtaoguo
force-pushed
the
hengtaoguo-pyconfig
branch
from
64aac3f to
fd028e0
Compare
bvandermoon
approved these changes
Feb 27, 2026
Collaborator
bvandermoon
left a comment
bvandermoon
left a comment
There was a problem hiding this comment.
LGTM, thank you @hengtaoguo
dipannita08
approved these changes
Feb 27, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hengtaoguo
added a commit
that referenced
this pull request
Feb 27, 2026
Imported from GitHub PR #3266 # Description Move `pyconfig.py` and `pyconfig_deprecated.py` to under `src/maxtext/configs`. # Tests CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- fd028e0 by hengtaoguo <hengtaoguo@google.com>: update Merging this change closes #3266 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3266 from AI-Hypercomputer:hengtaoguo-pyconfig fd028e0 PiperOrigin-RevId: 875963255
4 tasks
hengtaoguo
added a commit
that referenced
this pull request
Feb 27, 2026
Imported from GitHub PR #3266 # Description Move `pyconfig.py` and `pyconfig_deprecated.py` to under `src/maxtext/configs`. # Tests CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- fd028e0 by hengtaoguo <hengtaoguo@google.com>: update Merging this change closes #3266 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3266 from AI-Hypercomputer:hengtaoguo-pyconfig fd028e0 PiperOrigin-RevId: 875963255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
pyconfig.pyandpyconfig_deprecated.pyto undersrc/maxtext/configs.Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.