Move deprecated SFT scripts and update the paths#3273
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 27, 2026
Merged
Move deprecated SFT scripts and update the paths#3273copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
hengtaoguo
changed the title
hengtaoguo
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
jacoguzo,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
hengtaoguo
changed the title
Collaborator
Author
|
The notebook test failure is unrelated to this change: https://github.com/AI-Hypercomputer/maxtext/actions/runs/22501907495/job/65190975612 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Feb 27, 2026
hengtaoguo
added a commit
that referenced
this pull request
Feb 27, 2026
Imported from GitHub PR #3273 # Description We used to have two SFT scripts ([commit](https://github.com/AI-Hypercomputer/maxtext/tree/ec3becb0af9fb90a1b855f40231faf823082aa48)): - `MaxText.sft_trainer`: Deprecated native version. It doesn't need a shim because few people are actively using it. Now moving to `maxtext.trainers.post_train.sft.train_sft_deprecated`. - `MaxText.sft.sft_trainer`: Tunix version. We've moved to `maxtext.trainers.post_train.sft.train_sft`. # Tests CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- 87d406f by hengtaoguo <hengtaoguo@google.com>: Update deprecated sft scripts Merging this change closes #3273 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3273 from AI-Hypercomputer:hengtaoguo-re2 87d406f PiperOrigin-RevId: 876379236
4 tasks
igorts-git
approved these changes
Feb 27, 2026
NuojCheng
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We used to have two SFT scripts (commit):
MaxText.sft_trainer: Deprecated native version. It doesn't need a shim because few people are actively using it. Now moving tomaxtext.trainers.post_train.sft.train_sft_deprecated.MaxText.sft.sft_trainer: Tunix version. We've moved tomaxtext.trainers.post_train.sft.train_sft.Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.