Skip to content

fixing vllm adapter install.#3279

Merged
bvandermoon merged 1 commit intomainfrom
nicogrande/post-train-install-fix
Feb 28, 2026
Merged

fixing vllm adapter install.#3279
bvandermoon merged 1 commit intomainfrom
nicogrande/post-train-install-fix

Conversation

@NicoGrande
Copy link
Copy Markdown
Collaborator

Description

Fixing path to MaxText vLLM adapter plugin.

Tests

uv pip install -e .[tpu-post-train] --resolution=lowest

install_maxtext_tpu_post_train_extra_deps

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @NicoGrande

@bvandermoon bvandermoon merged commit 5dfd6a4 into main Feb 28, 2026
46 of 47 checks passed
@bvandermoon bvandermoon deleted the nicogrande/post-train-install-fix branch February 28, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants