Generalizes Qwen3's partial RoPE implementation into a reusable PartialRotaryEmbedding layer. #3282
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
8e267f0 to
5d3a1f8
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
PartialRotaryEmbedding layer.
|
🤖 Hi @gagika, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @gagika, but I was unable to process your request. Please see the logs for more details. |
5d3a1f8 to
174c655
Compare
…e generic and reusable.
174c655 to
9fc7f95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generalizes Qwen3's partial RoPE implementation into a reusable
PartialRotaryEmbeddinglayer.Previously, partial RoPE was implemented specifically for Qwen3 as
Qwen3NextRotaryEmbedding. This PR refactors it to be model-agnostic to adopt partial RoPE across other architectures.Tests
tests/unit/partial_rotary_embedding_test.pythat verifies:partial_rotary_factor=0.5correctly rotates the first half of the hidden dimension and passes the second half through unmodified.partial_rotary_factor=1.0behaves identically to the baseRotaryEmbedding.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.