Fix SFT mask to avoid calculating loss on generation prompt tokens#3284
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 3, 2026
Merged
Fix SFT mask to avoid calculating loss on generation prompt tokens#3284copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
58dc8e7 to
92af6ba
Compare
SurbhiJainUSC
approved these changes
Mar 2, 2026
bvandermoon
approved these changes
Mar 2, 2026
92af6ba to
2a52097
Compare
SurbhiJainUSC
approved these changes
Mar 3, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modern models like Llama 3 or Qwen add generation prompt tokens to indicate the start of an
assistant response. These are appened during inference, therefore, are not part of the completion tokens.Many LLM fine-tuning frameworks, such as
unsloth+trl, andms-swift, do not calculate loss on the generation prompt.This PR aligns the MaxText SFT masking logic with these other frameworks
generation_prompttokens as part of prompt tokens here, hence, the loss would not be calculated during SFT.FIXES: b/475383130
Tests
Unit Test
Compare sft qwen3-4b initial loss
5.868to5.1988Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.