Migrate ArrayRecord parsing off TF#3304
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
baf249e to
5358507
Compare
f9452ad to
cb855ba
Compare
gagika
reviewed
Mar 5, 2026
518d94e to
1243433
Compare
gagika
approved these changes
Mar 9, 2026
SurbhiJainUSC
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ParseFeaturesfunction used by Grain pipeline use tf.io.parse_example to parse examples, which uses the proto from the tensorflow library. To remove tensorflow dependency, I download the proto files from tensorflow library, modify the path and compile. The proto files and the compiled *_pb.py files are now in input_pipeline/protos. Migrate ParseFeatures to use the input_pipeline/protos instead of tf. Also in input_pipeline_utils.py, move tensorflow from top level import to local import in the corresponding functions.Steps:
cd /mnt/disks/pd2/maxtext/src && protoc --proto_path=. --python_out=. maxtext/input_pipeline/protos/feature.proto maxtext/input_pipeline/protos/example.proto, this generates example_pb2.py and feature_pb2.pyTests
Before PR:
After PR
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.