Skip to content

[DECOUPLED-MODE] Add ICI parallelism logic for decoupled mode for partial rotary embedding test #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 10, 2026
Merged

[DECOUPLED-MODE] Add ICI parallelism logic for decoupled mode for partial rotary embedding test #3341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/unit/partial_rotary_embedding_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
from maxtext.layers.embeddings import PartialRotaryEmbedding, RotaryEmbedding
from maxtext.configs import pyconfig
from maxtext.utils import maxtext_utils
from tests.utils.test_helpers import get_test_config_path
from tests.utils.test_helpers import get_test_config_path, get_decoupled_parallelism_overrides


class PartialRotaryEmbeddingTest(unittest.TestCase):
Expand All @@ -42,10 +42,12 @@ class PartialRotaryEmbeddingTest(unittest.TestCase):
def setUp(self):
super().setUp()
# build a simple config and mesh like other embedding tests
extra_args = get_decoupled_parallelism_overrides()
self.cfg = pyconfig.initialize(
[sys.argv[0], get_test_config_path()],
run_name="test_embeddings",
enable_checkpointing=False,
**extra_args,
)
devices_array = maxtext_utils.create_device_mesh(self.cfg)
self.mesh = Mesh(devices_array, self.cfg.mesh_axes)
Expand Down
Loading