Fix ring of experts using TP#3351
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
NuojCheng
requested review from
A9isha,
NicoGrande,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
khatwanimohit
approved these changes
Mar 9, 2026
igorts-git
approved these changes
Mar 9, 2026
gobbleturk
approved these changes
Mar 9, 2026
suexu1025
reviewed
Mar 9, 2026
|
|
||
| # Sum up the partial outputs across the expert shards. | ||
| output = jnp.reshape(output, (-1, sequence_length, self.config.emb_dim)) | ||
| output = jnp.reshape(output, (-1, sequence_length, self.config.emb_dim // self.get_tensor_parallelism_size())) |
Collaborator
There was a problem hiding this comment.
Do we need manually rs gradient output?
Collaborator
Author
There was a problem hiding this comment.
If we rely on JAX autodiff then no. If custom vjp then probably yes.
NuojCheng
force-pushed
the
chengnuojin-fix-ring-tp
branch
from
efdffea to
e3fa572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
use_ring_of_experts=Trueand TP is enabled, a sharding shape error appears. This PR fixes it by adding constraint on the unpermute shapes.FIXES: b/490177598
Tests
CI tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.