Fix config resolution for pip installed maxtext#3356
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 10, 2026
Merged
Fix config resolution for pip installed maxtext#3356copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
khatwanimohit
approved these changes
Mar 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Mar 10, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
Awesome, thank you @dipannita08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we run maxtext workload with pip-installed maxtext, the config path does not get resolved correctly resulting in the need to clone MaxText to pass config when running with pip.
The
resolve_config_pathnow handles this case, by resolving the config file usingMAXTEXT_CONFIGS_DIR.The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/491156065
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.