Skip to content

Create unit tests for Extract Hash Answer#3365

Merged
copybara-service[bot] merged 1 commit intomainfrom
rl-utils-tests
Mar 10, 2026
Merged

Create unit tests for Extract Hash Answer#3365
copybara-service[bot] merged 1 commit intomainfrom
rl-utils-tests

Conversation

@Shuwen-Fang
Copy link
Copy Markdown
Collaborator

@Shuwen-Fang Shuwen-Fang commented Mar 10, 2026 •
edited
Loading

Description

This tests extract_hash_answer for inputs with and without "#### " prefix.

Tests

All tests pass with pytest -rs tests/unit/rl_utils_test.py

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Shuwen-Fang
Shuwen-Fang commented Mar 10, 2026
View reviewed changes
Comment thread docs/run_maxtext/run_maxtext_via_xpk.md Outdated
@Shuwen-Fang
Add section on running with AOT compilation via XPK
f11d00d 
Add unit tests for extract_hash_answer

undo xpk doc change

undo doc changes

sync doc changes
@Shuwen-Fang Shuwen-Fang self-assigned this Mar 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@copybara-service copybara-service Bot merged commit 05c5083 into main Mar 10, 2026
48 checks passed
@copybara-service copybara-service Bot deleted the rl-utils-tests branch March 10, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hengtaoguo hengtaoguo hengtaoguo approved these changes

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@igorts-git igorts-git igorts-git approved these changes

@jacoguzo jacoguzo Awaiting requested review from jacoguzo

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner

@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner

@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner

@suexu1025 suexu1025 Awaiting requested review from suexu1025 suexu1025 is a code owner

@NicoGrande NicoGrande Awaiting requested review from NicoGrande NicoGrande is a code owner

@jesselu-google jesselu-google Awaiting requested review from jesselu-google jesselu-google is a code owner

@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner

Assignees

@Shuwen-Fang Shuwen-Fang

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shuwen-Fang @hengtaoguo @khatwanimohit @igorts-git