Fix NNX ValueError in NNXDecoder#3429
Merged
copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom Mar 17, 2026
Merged
Fix NNX ValueError in NNXDecoder#3429copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom
copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
63254c2 to
8b7b89e
Compare
NicoGrande
approved these changes
Mar 17, 2026
shralex
approved these changes
Mar 17, 2026
bvandermoon
approved these changes
Mar 17, 2026
df0487f
into
AI-Hypercomputer:main
55 of 58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix the NNX ValueError
ValueError: Cannot assign data value of type '<class 'maxtext.layers.nnx_wrappers.ToNNX'>' to static attribute 'decoder' of Pytree type '<class 'maxtext.models.models.Transformer'>'.
Tests
Run distill_train
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.