Skip to content

Fix NNX ValueError in NNXDecoder#3429

Merged
copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom
CIeNET-International:charlesli/fix_nnx_error
Mar 17, 2026
Merged

Fix NNX ValueError in NNXDecoder#3429
copybara-service[bot] merged 1 commit intoAI-Hypercomputer:mainfrom
CIeNET-International:charlesli/fix_nnx_error

Conversation

@charlesli640
Copy link
Copy Markdown
Collaborator

Description

To fix the NNX ValueError
ValueError: Cannot assign data value of type '<class 'maxtext.layers.nnx_wrappers.ToNNX'>' to static attribute 'decoder' of Pytree type '<class 'maxtext.models.models.Transformer'>'.

Tests

Run distill_train

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/models/models.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@charlesli640 charlesli640 force-pushed the charlesli/fix_nnx_error branch from 63254c2 to 8b7b89e Compare March 16, 2026 22:37
@copybara-service copybara-service Bot merged commit df0487f into AI-Hypercomputer:main Mar 17, 2026
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants