Distillation optimizer fix#3446
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
entrpn
approved these changes
Mar 18, 2026
23874df to
22de090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of ModelBundle in the distill pipeline, it allocates the optimizer state for both models in the base Tunix peft trainer.
Since the optimizer logic is completely revised in the MaxTextDistillationTrainer anyway, the fix is simply to send a dummy optimizer to the base class.
Tests
Not appllicable
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.