Fix tokenizer loading for logit check#3544
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
6fe4b32 to
38b30e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RissyRan
reviewed
Apr 1, 2026
38b30e5 to
0b0281e
Compare
0b0281e to
48d1761
Compare
bvandermoon
approved these changes
Apr 1, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
LGTM, once @RissyRan's comment is also resolved. Thank you @shuningjin for this fix
RissyRan
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix tokenizer loading for forward pass logit check. b/497054985
test_args.hf_model_pathis local, load fromconfig.tokenizer_path.test_args.hf_model_pathfirst (eliminate the need of manually set config.tokenizer_path),config.tokenizer_path(e.g., dequantized hf checkpoint may not include tokenizer like gpt-oss)Tests
Case 1: load from
test_args.hf_model_pathhttps://paste.googleplex.com/5308075478220800
Case 2: fallback to
config.tokenizer_pathhttps://paste.googleplex.com/4519457809629184
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.