Skip to content

Make missing ReadTheDocs fields editable in convert_checkpoint.md#3545

Merged
copybara-service[bot] merged 1 commit intomainfrom
bvandermoon-uxr
Apr 2, 2026
Merged

Make missing ReadTheDocs fields editable in convert_checkpoint.md#3545
copybara-service[bot] merged 1 commit intomainfrom
bvandermoon-uxr

Conversation

@bvandermoon
Copy link
Copy Markdown
Collaborator

@bvandermoon bvandermoon commented Apr 1, 2026

Description

  • Make missing ReadTheDocs fields editable in convert_checkpoint.md
  • Alphabetize the list
  • Update links to setup_gcsfuse which were causing link-checker to fail for this PR

FIXES: b/497817152

Tests

Built RTD locally and the fields in convert_checkpoint.md are now editable

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bvandermoon bvandermoon changed the title Make missing ReadTheDocs fields editable Make missing ReadTheDocs fields editable in convert_checkpoint.md Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@jacoguzo jacoguzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small suggestion. For some reason the landing pages for each section are appearing like this : https://screenshot.googleplex.com/3HB5KUMSouvbkTP. I'm not sure if it is simply an error in my build, could you check if this is broken?

Comment thread docs/_static/js/editable_commands.js
@bvandermoon
Copy link
Copy Markdown
Collaborator Author

Added a small suggestion. For some reason the landing pages for each section are appearing like this : https://screenshot.googleplex.com/3HB5KUMSouvbkTP. I'm not sure if it is simply an error in my build, could you check if this is broken?

Nice find, it doesn't seem related to this change as far as I can tell. It also is doing this for me even on the actual RTD pages: https://maxtext.readthedocs.io/en/latest/tutorials.html. We will need to figure out what's happening here

@bvandermoon
Copy link
Copy Markdown
Collaborator Author

Added a small suggestion. For some reason the landing pages for each section are appearing like this : https://screenshot.googleplex.com/3HB5KUMSouvbkTP. I'm not sure if it is simply an error in my build, could you check if this is broken?

Nice find, it doesn't seem related to this change as far as I can tell. It also is doing this for me even on the actual RTD pages: https://maxtext.readthedocs.io/en/latest/tutorials.html. We will need to figure out what's happening here

@Shuwen-Fang could you please take a look as the current onduty?

@jacoguzo jacoguzo self-requested a review April 2, 2026 18:39
@copybara-service copybara-service Bot merged commit e28978e into main Apr 2, 2026
37 checks passed
@copybara-service copybara-service Bot deleted the bvandermoon-uxr branch April 2, 2026 21:11
@Shuwen-Fang
Copy link
Copy Markdown
Collaborator

#3560 PR to fix tutorial display issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants