Add unit tests for embeddings.py and RoPE variants#3706
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 20, 2026
Merged
Add unit tests for embeddings.py and RoPE variants#3706copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d7e0d44 to
5d6c0aa
Compare
5d6c0aa to
e103e63
Compare
gobbleturk
approved these changes
Apr 20, 2026
NuojCheng
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for
src/maxtext/layers/embeddings.py, covering:Embedclass: Basic call andattendmethod.RotaryEmbeddingclass: Basic call.PartialRotaryEmbedding,Gemma4PartialRotaryEmbedding,LLaMARotaryEmbedding, andYarnRotaryEmbedding.These tests help ensure the correctness of these complex embedding layers and protect against future regressions.
Tests
I tested this change by running the new unit tests on a TPU VM.
Command:
pytest tests/unit/embeddings_test.pyResult:
7 passedChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.