Save run manifest for distillation reproducibility.#3709
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 22, 2026
Merged
Save run manifest for distillation reproducibility.#3709copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
🤖 Hi @gagika, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR introduces a helpful feature to save the run manifest (the source YAML configuration and the exact shell command) to the output directory. This significantly improves the reproducibility of distillation runs by allowing users to easily see and re-run the exact configuration used.
🔍 General Feedback
- The implementation is clean and follows the pattern of existing MaxText utilities by using
etils.epathfor cross-platform and cloud storage support. - The use of
jax.process_index() == 0correctly ensures that only the lead process handles the file writing. - The inclusion of unit tests covering both successful file generation and error handling is excellent.
- The minor suggestions provided aim to make the argument handling more robust against edge cases.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
JamesDeng42
approved these changes
Apr 21, 2026
Collaborator
JamesDeng42
left a comment
There was a problem hiding this comment.
thanks for this improvement, will make our life easier.
vlad-karp
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Save
distillation.ymlandcommand.sh(CLI overrides) to the run's output directory at startup, so a run can be reproduced by copying the YAML and re-running the saved command.etils.epath. Host-0 only.Tests
Unit test and end to end test.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.