Skip to content

Add activation batch attn and rename some attn logical names#3714

Merged
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-attn-batch
Apr 22, 2026
Merged

Add activation batch attn and rename some attn logical names#3714
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-attn-batch

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Apr 22, 2026

Description

This PR introduces a new logical name activation_batch_attn, which shares the same sharding rule with activation_batch for training. It (will) share different rules in vllm inference.

This PR also renames activation_attn_length to activation_length_attn to follow the tradition that compnent names should be at last.

Tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@NicoGrande NicoGrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this!

@NuojCheng NuojCheng force-pushed the chengnuojin-attn-batch branch from 7262655 to f6a0110 Compare April 22, 2026 20:49
@copybara-service copybara-service Bot merged commit f67d8b1 into main Apr 22, 2026
26 checks passed
@copybara-service copybara-service Bot deleted the chengnuojin-attn-batch branch April 22, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants