make AddLabel workflow work as expected#3733
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
charlesli640
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
8 times, most recently
from
7a34741 to
4b449ec
Compare
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
from
ee9d8c2 to
e274882
Compare
charlesli640
commented
Apr 24, 2026
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
from
e274882 to
3bd6a89
Compare
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
5 times, most recently
from
d38d030 to
30cb865
Compare
charlesli640
commented
Apr 27, 2026
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
2 times, most recently
from
d3a56db to
792ac19
Compare
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
3 times, most recently
from
7712497 to
b3ad9a2
Compare
shralex
approved these changes
Apr 28, 2026
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
3 times, most recently
from
f784a0d to
7115859
Compare
shralex
approved these changes
Apr 28, 2026
Add Label when approval count >= 2 Make AddLabel workflow in chain of "MaxText Package Tests" Make AddLabel workflow to fail by core.setFailed when condition is not met
charlesli640
force-pushed
the
charlesli/debug_secrets_empty
branch
from
7115859 to
2e49a25
Compare
khatwanimohit
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make Add Label workflow work - adding Label "pull ready" when PR got approved.
1.Make AddLabel workflow in chain of "MaxText Package Tests".
2.Make AddLabel workflow to fail by
core.setFailed + return;when condition is not met3.Need >=2 approvals (with different approvers) to set the "pull ready" label
Tests
CI/CD
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.