Skip to content

Add remove size one func to eval dataloader#3754

Merged
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-eval-sharding
Apr 27, 2026
Merged

Add remove size one func to eval dataloader#3754
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-eval-sharding

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Apr 27, 2026

Description

Since remove_size_one_mesh_axis_from_type is tuned as False in batch split implementation, some redundant physical axes, e.g. context, data, are included in eval data iterators. This PR additionally enforces size one mesh axes get ignored when the eval data get generated.

Tests

Repro in v5p-8 vm: https://paste.googleplex.com/5394820295163904

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RissyRan RissyRan marked this pull request as ready for review April 27, 2026 19:11
Copy link
Copy Markdown
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please ensure tests are passing as well.

@copybara-service copybara-service Bot merged commit c52e345 into main Apr 27, 2026
52 of 55 checks passed
@copybara-service copybara-service Bot deleted the chengnuojin-eval-sharding branch April 27, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants