Refactor: extract shared post-training hooks and update SFT implementation#3862
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
86e8ff4 to
784f4e5
Compare
4 tasks
950adfd to
f62df0f
Compare
shralex
approved these changes
May 11, 2026
SurbhiJainUSC
approved these changes
May 11, 2026
f62df0f to
99e947e
Compare
NicoGrande
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generalize the SFT hooks such that they can be used in DPO as well.
We move the shared code into
src/maxtext/trainers/post_train/hooks.pywhile the SFT-specific overrides reside in the SFT sub-directory.This PR is a pre-requisite for #3668 (DPO implementation)
Tests
Test run of a local SFT training.
Ran the unit tests, including logits comparison test.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.