Fix AotHloIdenticalTest false-positive failure on JAX nightly due to new source mapping format#3947
Merged
Merged
Conversation
…new source mapping format
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4589913 to
480a5ec
Compare
khatwanimohit
approved these changes
May 19, 2026
NuojCheng
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Ahead-Of-Time (AOT) identical graph verification tests to ignore new XLA debug source location metadata. This fixes false-positive integration test failures occurring under newer JAX/XLA nightly environments.
The Problem Being Solved:
JAX/XLA nightly recently introduced a new debug source mapping metadata format in the compiled HLO headers (
file_location_idandparent_frame_id). Because Ahead-Of-Time compilation (train_compile.py) and normal JIT compilation (train.py) have different call stacks, these generated frame IDs differ.The test's sanitation regex
location_map_patterndid not filter outfile_location_id, triggering a false-positiveAotHloIdenticalTest::test_default_hlo_matchfailure even though the actual compiled hardware instructions are 100% identical.The Solution:
Updated the
location_map_patternregex intests/integration/aot_identical_test.pyto match and strip bothfile_name_idand the newfile_location_idmetadata blocks before comparing AOT and Real hashes:FIXES: b/514475466
FIXES: #3941
Tests
Build Images workflow no longer fails with AOT identical graph test.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.