Cache already downloaded HuggingFace shards.#3972
Open
niting wants to merge 1 commit into
Open
Conversation
Currently, shards seem to be redownloaded every time they are required causing slowdowns in conversion. Tried running the script with the changes and there's significant improvements. Benchmark: 2-Layer Qwen3 MoE Checkpoint Conversion (Lazy Loading Enabled) | Metric | Baseline (Cached) | Optimized (Phase 1 Only) | Speedup | |------------------------------|-------------------|--------------------------|----------| | Sharding (Materialization) | 81.6s (1.36 min) | 16.2s (0.27 min) | **5.0x** | | Overall Elapse | 83.4s (1.39 min) | 17.4s (0.29 min) | **4.8x** | Integration Tests (tests/integration/checkpoint_conversion_test.py): - Baseline: 148.73s (2:28) - Optimized: 77.33s (1:17) -> **1.9x speedup overall** (includes model download)
niting
requested review from
NicoGrande,
RissyRan,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
parambole,
richjames0,
shralex,
shuningjin and
suexu1025
as code owners
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, shards seem to be redownloaded every time they are required causing slowdowns in conversion. Tried running the script with the changes and there's significant improvements.
Benchmark: 2-Layer Qwen3 MoE Checkpoint Conversion (Lazy Loading Enabled)
Integration Tests (tests/integration/checkpoint_conversion_test.py):
Tests
Ran the conversion script to confirm it works.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.