pre-populate MODEL and remove --zone from multi-host RL tutorial#3986
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| # The MaxText model name. See `src/maxtext/configs/types.py` for `ModelName` for a | ||
| # full list of supported models. | ||
| export MODEL=<MODEL_NAME> # e.g. 'llama3.1-70b-Instruct' | ||
| export MODEL=llama3.1-70b-Instruct # replace with another model from src/maxtext/configs/types.py if needed |
There was a problem hiding this comment.
It might be better if this was left as is? The existing state forces the user to actively set a model (which errors out when they forget to do so). Pre-setting a model might cause them to forget to update this causing a mismatch with what they might be expecting. This is a fillable box anyway on the documentation.
There was a problem hiding this comment.
+1 please leave the editable variable name as is
bvandermoon
left a comment
There was a problem hiding this comment.
LGTM outside of the <MODEL_NAME> comment from @niting
| # The MaxText model name. See `src/maxtext/configs/types.py` for `ModelName` for a | ||
| # full list of supported models. | ||
| export MODEL=<MODEL_NAME> # e.g. 'llama3.1-70b-Instruct' | ||
| export MODEL=llama3.1-70b-Instruct # replace with another model from src/maxtext/configs/types.py if needed |
There was a problem hiding this comment.
+1 please leave the editable variable name as is
b5e5f90 to
7c976c2
Compare
Pre-populate MODEL with the tutorial's specific model name so users don't need to hunt through types.py. Remove --zone from xpk commands, consistent with the existing note that XPK v0.14+ auto-discovers cluster location.
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.