[slice] Validate cube count#1036
Conversation
There was a problem hiding this comment.
Why did we change topology dimensions
There was a problem hiding this comment.
Notice that these Unit Tests were (by default) using basePodSetAssignment1Wrapper and basePodSetAssignment2Wrapper, which were returning assignments with only a single cube. Also the baseSlice1Wrapper, was a slice with 4x4x12 topology and a single cube.
So, basically we were only testing the path where the number of cubes in a slices did not match the topology (so, the one that was causing the slices to hang as we observed recently). And this is exactly the path that we want to reject with validation in this PR.
So, I had to fix all the Unit Tests.
There was a problem hiding this comment.
I think this is no longer accurate
| }) | ||
| basePodSetAssignment2Wrapper := utiltesting.MakePodSetAssignment("ps2"). | ||
| TopologyAssignment(baseLevels, []kueue.TopologyAssignmentSlice{ | ||
| utiltesting.MakeTopologyAssignmentSlice(1, []int32{2}). |
There was a problem hiding this comment.
IIUC this assumes that we can fit two Pods on one Node. While it's not invalid, usually we do 1 pod per node assignment in real-world scenarios. Can we align it in a follow up?
There was a problem hiding this comment.
These tests define 4 nodes, each in a different cube. We can think how to make it more realistic in a followup.
|
LGTM, just nits |
3 participants
Description
Additional validation that checks if in the topology assignment returned by Kueue TAS, the number of cubes matches the expected number of cubes (from the topology).
Issue
Testing