fix: Limit super-slicing workload name#1087
Merged
jamOne- merged 3 commits intoAI-Hypercomputer:mainfrom Mar 2, 2026
Merged
Conversation
scaliby
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Super-slicing workload name limit.
Although it was suggested to consider a truncating logic, it would not be so trivial to keep the names consistent accross many commands. We'd have to truncate the names everywhere. Otherwise it'd lead to unexpected results, like user creates a workload with long name, then they cannot see the workload on the
xpk workload list.Issue
http://b/477105590
Testing
unit tests