fix: correct placement of jobset exclusive placement annotations for Pathways#1122
Merged
jamOne- merged 3 commits intoAI-Hypercomputer:mainfrom Mar 16, 2026
Merged
Conversation
jamOne-
changed the title
jamOne-
requested review from
FIoannides,
SikaGrr,
scaliby and
stony-tark
as code owners
scaliby
approved these changes
Mar 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SikaGrr
approved these changes
Mar 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Kubernetes JobSet schema states that
exclusive-topologybelongs either at the top-levelJobSetmetadata or at theReplicatedJobtemplate metadata (spec.replicatedJobs[*].template.metadata.annotations), not thePodtemplate.Docs: https://jobset.sigs.k8s.io/docs/concepts/#exclusive-job-to-topology-placement.
Issue
Gemini finding, no bug.
Testing
verified manually, maxtext pathways workload succeeds.