Fix GKE node version selection logic#185
Closed
44past4 wants to merge 0 commit into
Closed
Conversation
Obliviour
approved these changes
Sep 18, 2024
Collaborator
Obliviour
left a comment
Obliviour
left a comment
There was a problem hiding this comment.
LGTM, Is it possible that the rapid release will not have a release of the same major version or lower? The current default rapid release version is 1.31 and it is currently and has support for versions old as 1.27x. 1.27x was introduced in May 2023. So I am guessimating that a major version will be in the rapid release for 1.5 years. If a user doesn't upgrade their cluster for that long then, this logic may break again.
Collaborator
|
@44past4 I gave you permissions to the project, I believe folks will not run the Build test properly due to permissions, do you mind moving this to a branch based PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Tested manually