Skip to content

Implement batch command - basic version#208

Merged
pawloch00 merged 26 commits into
mainfrom
ppawl-implement-batch
Nov 4, 2024
Merged

Implement batch command - basic version#208
pawloch00 merged 26 commits into
mainfrom
ppawl-implement-batch

Conversation

@pawloch00
Copy link
Copy Markdown
Contributor

@pawloch00 pawloch00 commented Oct 16, 2024 •
edited
Loading

Fixes / Features

  • This command allows for execution of batch script in basic version, it does not mounts any volumes. Executed script should not rely on other files. Further instructions on installing kjob and necessary prerequisites will be added in Create kjob profile in cluster create command #212

https://github.com/kubernetes-sigs/kueue/blob/main/cmd/experimental/kjobctl/docs/run_slurm.md

https://github.com/kubernetes-sigs/kueue/blob/main/cmd/experimental/kjobctl/docs/installation.md

Testing / Documentation

Testing details.

  • [ y ] Tests pass
  • [ n ] Appropriate changes to documentation are included in the PR - another PR on the way with docs

@pawloch00
add batch skeleton
21936c6 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
add job_template
b7b1bdc 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
implement job_template from yaml string
d681b88 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
fix formatting
be9ace0 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
remove templates
2db6f5b 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
add basic batch impl
7c63e48 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
fix pylint
3d29a29 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
remove core
2d9375f 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
Merge branch 'main' into ppawl-implement-batch
886429f
@pawloch00 pawloch00 marked this pull request as ready for review October 16, 2024 13:11
@pawloch00 pawloch00 requested a review from BluValor October 16, 2024 13:11
@pawloch00
fix print and newlines
6c0575a 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
fix formatting
6d15e78 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
remove unused var
9a3bf1f 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
fix typo
48d00a9 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
BluValor
BluValor reviewed Oct 17, 2024
View reviewed changes
Comment thread src/xpk/commands/batch.py
BluValor
BluValor reviewed Oct 17, 2024
View reviewed changes
Comment thread src/xpk/core/app_profile.py
BluValor
BluValor reviewed Oct 17, 2024
View reviewed changes
Comment thread src/xpk/core/job_template.py
@pawloch00 pawloch00 requested a review from BluValor October 17, 2024 08:44
BluValor
BluValor previously approved these changes Oct 17, 2024
View reviewed changes
@pawloch00
remove unused vars
86a5d83 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
remove unused
849e012 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
remove unused import
a2b094d 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
remove passing script args
961d587 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
linter fix
155752d 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
BluValor
BluValor previously approved these changes Oct 18, 2024
View reviewed changes
@pawloch00 pawloch00 requested a review from BluValor October 22, 2024 10:00
@BluValor BluValor mentioned this pull request Oct 29, 2024
Merged
@mbobrovskyi
Copy link
Copy Markdown
Collaborator

mbobrovskyi commented Nov 4, 2024

Can we merge this PR?

@pawloch00 pawloch00 merged commit 3aba146 into main Nov 4, 2024
@pawloch00 pawloch00 deleted the ppawl-implement-batch branch November 4, 2024 15:34
@mbobrovskyi
Copy link
Copy Markdown
Collaborator

mbobrovskyi commented Nov 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharabiani sharabiani Awaiting requested review from sharabiani

@Obliviour Obliviour Awaiting requested review from Obliviour

@44past4 44past4 Awaiting requested review from 44past4

1 more reviewer

@BluValor BluValor BluValor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawloch00 @mbobrovskyi @BluValor